feat: make improvements to org table #10679
Conversation
github-actions
bot
added
Template::Toolkit
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10679 +/- ##
==========================================
- Coverage 49.54% 49.22% -0.33%
==========================================
Files 67 77 +10
Lines 20650 22093 +1443
Branches 4980 5277 +297
==========================================
+ Hits 10231 10875 +644
- Misses 9131 9890 +759
- Partials 1288 1328 +40 ☔ View full report in Codecov by Sentry. |
cgi/display_org_table.pl
Outdated
| SCRIPTS | ||
| ; | ||
|
|
||
| $request_ref->{header} .= <<HEADER | ||
| <link rel="stylesheet" href="https://static.openfoodfacts.org/js/datatables.min.css"> | ||
| <link rel="stylesheet" href="https://cdn.datatables.net/buttons/2.3.6/css/buttons.dataTables.min.css"> |
There was a problem hiding this comment.
Could you create a new version of the datatables.css and so on, which include the buttons? Alternatively, move DataTables to be downloaded from npm and bundled with webpack. We should ensure we use a consistent version, and we want to avoid using CDNs our assets.
There was a problem hiding this comment.
I'm not sure how to go about this @hangy
There was a problem hiding this comment.
@TheSussex When you look at https://github.com/TheSussex/openfoodfacts-server/blob/9e1dd240ce9a1b4e51e7a3dcd8ac6f03aeaaf57b/html/js/datatables.css#L7-L10, you can see that the datatables we currently publish with some specific settings. If you go to that link, you can select the buttons component to be bundled, too. The simplest version would be to simply download the modified CSS and JS files from the datatables site and then replace the ones currently in git.
There was a problem hiding this comment.
I did this and it's not showing the column visibility button anymore. Am I supposed to rebuild or what?
There was a problem hiding this comment.
I did this and it's not showing the column visibility button anymore. Am I supposed to rebuild or what?
Yes, can you try rebuilding, please? Just the frontend (make front_build if you're using docker) should be enough.
There was a problem hiding this comment.
This did not work @hangy
There was a problem hiding this comment.
@hangy @TheSussex I updated the JS files and included the ordering etc. buttons. They were also loaded with a hardcoded path to static.openfoodfacts.org, that's why they were not picked in a local dev environment.
github-actions
bot
added
🏭 Producers Platform
|
What
templates/web/common/site_layout.tt.htmlfile to include a link only visible to admins and moderators in the homepage menu, this link leads to the organization table page./cgi/display_org_table.plfile to persist search queries values in the form after submission.creatorfield withcreator_emailScreenshot